Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add mocha eslint rules #2848

Merged
merged 9 commits into from Apr 30, 2024
Merged

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Apr 26, 2024

This adopts eslint-plugin-mocha to provide some conventions for our tests (importantly to avoid future issues such those discovered in #2846.

  • I changed several rules to warn instead of error in order to defer some work to later and allow some flexibility for us
  • A few packages related to eslint, mocha, and chai were updated along the way
  • The large number of files changes is mostly due to automatically --fixing the mocha/no-mocha-arrows rule
  • I made the rules to ignore javascript test files entirely since we plan to migrate those tests anyway

@eablack eablack self-assigned this Apr 26, 2024
@eablack eablack marked this pull request as ready for review April 29, 2024 23:44
@eablack eablack requested a review from a team as a code owner April 29, 2024 23:44
Copy link
Contributor

@k80bowman k80bowman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for digging into this!

@eablack eablack merged commit 89201a4 into prerelease/9.0.0-alpha Apr 30, 2024
8 checks passed
@eablack eablack deleted the eb/add-eslint-mocha branch April 30, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants