New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add mocha eslint rules #2848
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eablack
force-pushed
the
eb/add-eslint-mocha
branch
from
April 29, 2024 18:22
f85b90f
to
6dbe1c2
Compare
eablack
force-pushed
the
eb/add-eslint-mocha
branch
from
April 29, 2024 20:16
5b1d92f
to
3f4f208
Compare
eablack
force-pushed
the
eb/add-eslint-mocha
branch
from
April 29, 2024 23:19
1dfe311
to
1cfad0c
Compare
… misc linting errors
eablack
force-pushed
the
eb/add-eslint-mocha
branch
from
April 30, 2024 00:11
3a92da7
to
72076e9
Compare
k80bowman
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for digging into this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adopts eslint-plugin-mocha to provide some conventions for our tests (importantly to avoid future issues such those discovered in #2846.
warn
instead of error in order to defer some work to later and allow some flexibility for us--fix
ing themocha/no-mocha-arrows
rule