Explicitly install libreadline-dev when building Python runtimes
#1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required so that the `readline` and `curses` stdlib modules will be built, now that `libreadline-dev` is intentionally no longer in the Heroku-24 build image: heroku/base-images#296 (These headers are only needed when the Python runtimes are being compiled. The run image still has the necessary runtime library counterparts.)
edmorley
added a commit
to heroku/docker-heroku-ruby-builder
that referenced
this pull request
May 9, 2024
Since it's no longer in the Heroku-24 build image after: heroku/base-images#296 (The headers are only needed when the Ruby runtimes are being compiled. The run image still has the necessary runtime library counterparts.) See also: heroku/heroku-buildpack-python#1580
edmorley
added a commit
to heroku/docker-heroku-ruby-builder
that referenced
this pull request
May 9, 2024
Since it's no longer in the Heroku-24 build image after: heroku/base-images#296 (The headers are only needed when the Ruby runtimes are being compiled. The run image still has the necessary runtime library counterparts.) See also: heroku/heroku-buildpack-python#1580
runesoerensen
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required so that the Python
readlineandcursesstdlib modules will be built, now that libreadline-dev is intentionally no longer in the Heroku-24 build image: heroku/base-images#296(These headers are only needed when the Python runtimes are being compiled. The run image still has the necessary runtime library counterparts.)
GUS-W-15159536.