ignore sigterm #14
Merged
ignore sigterm #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like CI has bitrotted :( |
tcrayford
added a commit
to heroku/heroku-buildpack-l2met-shuttle
that referenced
this pull request
Aug 19, 2019
This rewrites `start-l2met-shuttle`, and uses a binary from heroku/l2met-shuttle#14 that ignores `SIGTERM` This is because, on heroku dynos, the dyno manager sends SIGTERM to every process when doing a graceful shutdown. During that time period, we still want logging to happen and metrics to be sent. With the prior implementation, the `tee` processes would exit the moment the dyno got told to shutdown. In the new implementation, `l2met-shuttle` hangs around until the process it's reading from dies.
tcrayford
force-pushed
the
only_sigterm_after_shutting_down
branch
from
dc1a992
to
6eb6687
Compare
beanieboi
approved these changes
Aug 20, 2019
|
@tt Is the |
|
Let's pick that work up sometime @edmorley ;) |
|
For folks reading this later, there's a slack discussion on this here: https://heroku.slack.com/archives/CA5BNBLDR/p1566300448040700 |
tcrayford
added a commit
to tcrayford/heroku-buildpack-l2met-shuttle
that referenced
this pull request
Aug 23, 2019
This rewrites `start-l2met-shuttle`, and uses a binary from heroku/l2met-shuttle#14 that ignores `SIGTERM` This is because, on heroku dynos, the dyno manager sends SIGTERM to every process when doing a graceful shutdown. During that time period, we still want logging to happen and metrics to be sent. With the prior implementation, the `tee` processes would exit the moment the dyno got told to shutdown. In the new implementation, `l2met-shuttle` hangs around until the process it's reading from dies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets the
l2met-shuttleprogram to ignoreSIGTERMentirely.This is because, on heroku dynos, the dyno manager sends
SIGTERMto every process when doing a graceful shutdown. During that time period, we still want logging to happen and metrics to be sent.The prior implementation of
l2met-shuttleleads to all logs going missing the moment a dyno starts shutting down, and usually that will crash the "main" processl2met-shuttleis a sidecar for.