Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small addition of tags and categories + home page #26

Merged
merged 4 commits into from
Jul 1, 2020
Merged

small addition of tags and categories + home page #26

merged 4 commits into from
Jul 1, 2020

Conversation

achauvinhameau
Copy link
Contributor

add loc for the home page with current date and tags/categories if configured in the _config.xml

@coveralls
Copy link

coveralls commented Aug 19, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling cb5dfeb on achauvinhameau:evol-tags-and-cats into a45bedd on hexojs:master.

@NoahDragon
Copy link
Member

Could you please make the travis ci happier? 😄

@coveralls
Copy link

coveralls commented Aug 21, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 64cf502 on achauvinhameau:evol-tags-and-cats into a45bedd on hexojs:master.

@achauvinhameau
Copy link
Contributor Author

the failling test in travis is linked to a change I've made for the root url (adding date). Let you check wether you want to keep it.

@NoahDragon
Copy link
Member

I see. Could you please also fix the test file and add test cases for your changes? This will make the future development easier. 😄

@coveralls
Copy link

coveralls commented Aug 26, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling e7e6572 on achauvinhameau:evol-tags-and-cats into a45bedd on hexojs:master.

@coveralls
Copy link

coveralls commented Aug 26, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling f76a810 on achauvinhameau:evol-tags-and-cats into a45bedd on hexojs:master.

@coveralls
Copy link

coveralls commented Aug 26, 2017 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 1abed6c on achauvinhameau:evol-tags-and-cats into b8fc737 on hexojs:master.

@NoahDragon
Copy link
Member

Thank you. LGTM.

@chawyehsu
Copy link

Are there any changes required to make this be merged?

tomap
tomap previously approved these changes Jan 14, 2019
View reviewed changes
@tomap
Copy link
Contributor

tomap commented Jan 14, 2019

LGTM too

@geektutu
Copy link

Adding loc for the home page is nice, is there anyone who would click merge button ?

@mattlin4567
Copy link

什麼時候才能增加 tags 和 category 啊

@curbengh curbengh force-pushed the evol-tags-and-cats branch 3 times, most recently from 94eb825 to 33b9424 Compare June 30, 2020 13:15
@curbengh curbengh requested a review from a team June 30, 2020 13:20
@curbengh
Copy link
Contributor

Rebased.

SukkaW
SukkaW previously approved these changes Jun 30, 2020
View reviewed changes
Copy link
Member

@SukkaW SukkaW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@SukkaW
Copy link
Member

SukkaW commented Jun 30, 2020

@curbengh Ops. Seems that it needs to be rebased again.

@curbengh
Copy link
Contributor

curbengh commented Jul 1, 2020

Rebased. Updated sNow to be date only.

@curbengh curbengh requested a review from SukkaW July 1, 2020 00:41
@SukkaW
Copy link
Member

SukkaW commented Jul 1, 2020

Approved.

@SukkaW SukkaW merged commit abd17a4 into hexojs:master Jul 1, 2020
This was referenced Jul 1, 2020
Closed
Closed
Closed
@curbengh curbengh mentioned this pull request Aug 2, 2020
Merged
@uiolee uiolee mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SukkaW SukkaW SukkaW approved these changes

@tomap tomap tomap left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@achauvinhameau @coveralls @NoahDragon @chawyehsu @tomap @geektutu @mattlin4567 @curbengh @SukkaW