WIP fix: use canonical url for pages #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curbengh
changed the title
2 tasks
Merged
11 tasks
2 tasks
|
LGTM, except the conflict :) |
curbengh
force-pushed
the
canonical
branch
4 times, most recently
from
aed9a3d
to
7e6212c
Compare
|
Rebased. |
|
Might wait hexojs/hexo#3691 ? |
curbengh
changed the title
|
you're right, this PR is not necessary in hexojs/hexo#3691 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
index.htmlfrom url of pages. Fixes #13. Based on https://github.com/pyyzcwg2833/hexo-generator-sitemap/commit/a92dbbb83cc39ff60d43faa5cd688a56574a3889 (credit @pyyzcwg2833).Added test for pages (closes #62). Updated the
updatedattribute of hexo.init() in the test for more predictable result.The affected code uses ES2018 feature (which is Node 8 supports). Refactor everything else to ES6 should be in a separate PR.
Feel free to refactor
.concat()and array-object-array conversion to something better."ecmaVersion": 2018can be removed once another PR hexojs/eslint-config-hexo#16 has been released (eslint-config-hexo@4).Pull request tasks