Skip to content

Commit

Permalink
Merge branch 'syslog'
Browse files Browse the repository at this point in the history
* syslog:
  Made frontik to log into syslog
  syslogging
  sysloggin
  • Loading branch information
Дмитрий Зубов committed Oct 19, 2010
2 parents 29cc936 + a7a29bf commit 5951e47
Show file tree
Hide file tree
Showing 12 changed files with 77 additions and 12 deletions.
21 changes: 17 additions & 4 deletions src/frontik.cfg.ex
@@ -1,10 +1,23 @@
host = 'localhost'
port = 8080
host = '0.0.0.0'
port = 8080
workers_count = 1

document_dir = '/var/www/frontik/'
daemonize = False

log_level = 'debug'
loglevel = 'debug'
logfile = None # log to stderr

syslog = True
syslog_address = "/dev/log"

pidfile = None

apps = { 'page' : '/path/' }

use_standart_doc = False

debug = True
debug_login = "hh"
debug_password = "12345"


2 changes: 1 addition & 1 deletion src/frontik/app.py
Expand Up @@ -4,7 +4,7 @@

import tornado.web
import tornado.ioloop
import logging
import frontik.log as logging
from tornado.options import options

import frontik.magic_imp
Expand Down
2 changes: 1 addition & 1 deletion src/frontik/async.py
Expand Up @@ -3,7 +3,7 @@
import time
import Queue

import logging
import frontik.log as logging
log = logging.getLogger('frontik.async')


Expand Down
3 changes: 2 additions & 1 deletion src/frontik/handler.py
Expand Up @@ -29,7 +29,7 @@
import frontik.handler_whc_limit
import frontik.handler_debug

import logging
import frontik.log as logging
log = logging.getLogger('frontik.handler')

import future
Expand Down Expand Up @@ -189,6 +189,7 @@ def __init__(self, ph_globals, application, request):
else:
self.apply_postprocessor = True


def require_debug_access(self):
if not tornado.options.options.debug:
frontik.auth.require_basic_auth(self, tornado.options.options.debug_login,
Expand Down
2 changes: 1 addition & 1 deletion src/frontik/handler_debug.py
@@ -1,4 +1,4 @@
import logging
import frontik.log as logging
import tornado
import weakref
import xml.sax.saxutils
Expand Down
2 changes: 1 addition & 1 deletion src/frontik/handler_xml.py
Expand Up @@ -13,7 +13,7 @@
import frontik.auth
import frontik.xml_util

import logging
import frontik.log as logging
lgo = logging.getLogger('frontik.server')
log_xsl = logging.getLogger('frontik.handler.xsl')
log_fileloader = logging.getLogger('frontik.server.fileloader')
Expand Down
22 changes: 22 additions & 0 deletions src/frontik/log.py
@@ -0,0 +1,22 @@


import tornado.options
import logging
import logging.handlers
from logging import *

Filterer = logging.Filterer

if tornado.options.options.syslog:
_syslog_formatter = logging.Formatter('[%(asctime)s %(name)s] %(levelname)s %(message)s')
_handler = logging.handlers.SysLogHandler(facility=logging.handlers.SysLogHandler.LOG_DEBUG, address=tornado.options.options.syslog_address)
_handler.setFormatter(_syslog_formatter)

def getLogger(*args, **kwargs):
log = logging.getLogger(*args, **kwargs)

if tornado.options.options.syslog:
tornado.options.options.syslog
log.addHandler(_handler)
return log

2 changes: 1 addition & 1 deletion src/frontik/magic_imp.py
Expand Up @@ -3,7 +3,7 @@
import imp
import functools

import logging
import frontik.log as logging
log = logging.getLogger('frontik.imp')

def gen_module_name(app_name, module_name=None):
Expand Down
1 change: 1 addition & 0 deletions src/frontik/util.py
Expand Up @@ -176,3 +176,4 @@ def _asciify_url_char(c):

def asciify_url(url):
return ''.join(map(_asciify_url_char, url))

2 changes: 1 addition & 1 deletion src/frontik/xml_util.py
@@ -1,4 +1,4 @@
import logging
import frontik.log as logging
import os.path

from frontik import etree
Expand Down
25 changes: 25 additions & 0 deletions src/frontik_dev.cfg
@@ -0,0 +1,25 @@
host = '0.0.0.0'
port = 8080
workers_count = 1

daemonize = False

loglevel = 'debug'
logfile = None # log to stderr

syslog = True
syslog_address = "/dev/log"
syslog_only = True

pidfile = None

apps = { 'zubov' : '/home/meerkat/work/frontik-www/frontik_www',
'proxy': '/home/meerkat/work/partner_proxy' }

use_standart_doc = False

debug = True
debug_login = "hh"
debug_password = "12345"


5 changes: 4 additions & 1 deletion src/frontik_srv.py
Expand Up @@ -20,6 +20,10 @@
tornado.options.define('apps', {}, dict)
tornado.options.define('suppressed_loggers', ['tornado.httpclient'], list)
tornado.options.define('handlers_count', 100, int)

tornado.options.define('syslog_address', "/dev/log", str)
tornado.options.define('syslog', False, bool)

tornado.options.define('debug', False, bool)
tornado.options.define('debug_login', None, str)
tornado.options.define('debug_password', None, str)
Expand All @@ -38,4 +42,3 @@
sys.exit(1)

tornado_util.server.main(app)

2 comments on commit 5951e47

@elephantum
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дима, а зачем ты сделал это так странно?

Достаточно было в frontik_srv.py повесить syslog_handler на рутовый логгер.

Текущее решение не очень хорошее, потому что обязывает использовать frontik.log вместо стандартного logging, люди об этом забывают.

@haxo
Copy link

@haxo haxo commented on 5951e47 Oct 22, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, ты прав.

Please sign in to comment.