Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HHH-18116 Support slow query logging for stored procedures #8382

Merged
merged 1 commit into from
May 16, 2024
Merged

HHH-18116 Support slow query logging for stored procedures #8382

merged 1 commit into from
May 16, 2024

Conversation

marschall
Copy link
Contributor

@marschall marschall commented May 14, 2024 •
edited by hibernate-github-bot bot

gavinking
gavinking requested changes May 15, 2024
View reviewed changes
Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm missing something, it seems to me that it be better to pass the SQL string to the constructor of ProcedureOutputsImpl and then to the constructor of OutputsImpl, instead of passing it as an argument to the executeStatement() method.

hibernate-core/src/main/java/org/hibernate/procedure/internal/ProcedureCallImpl.java Outdated Show resolved Hide resolved
hibernate-core/src/main/java/org/hibernate/result/internal/OutputsImpl.java Outdated Show resolved Hide resolved
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented May 16, 2024 •
edited

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@marschall
Copy link
Contributor Author

Unless I'm missing something, it seems to me that it be better to pass the SQL string to the constructor of ProcedureOutputsImpl and then to the constructor of OutputsImpl, instead of passing it as an argument to the executeStatement() method.

Fair point, corrected.

@marschall marschall closed this May 16, 2024
@marschall marschall reopened this May 16, 2024
gavinking
gavinking approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@gavinking gavinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@beikov beikov merged commit e2c1869 into hibernate:main May 16, 2024
22 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavinking gavinking gavinking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@marschall @gavinking @beikov