win32: Consider how isExecutable treated

[okuoku]

I'm going to temporarily comment-out Win32 isExecutable implementation since it doesn't compile on the latest source.

mosh/src/OSCompat.cpp

Lines 680 to 688 in 9353555

	if (isExist(path)) {
	const ucs4char* extensions[] = { UC(".COM"), UC(".EXE"), UC(".BAT"), UC(".VBS"), UC("VBE"),
	UC(".JS"), UC(".JSE"), UC(".WSF"), UC(".WSH"), UC(".MSC")};
	for (unsigned int i = 0; i < sizeof(extensions); i++) {
	if (endsWith(path, extensions[i])) {
	return true;
	}
	}
	}

(Since ucs4string is now explicit, we cannot instantiate them in this way.)

Win32 do not have "executable" bit on its filesystem so ultimately we cannot implement this. We can consider multiple implementations and need to choose one:

• a) Decide on file extension (Previous implementation)
  • consider "double-click-to-execute" files as executable.
  • Previous implementation is incomplete; use PATHEXT to get precise result
  • Pros:
    • ????
  • Cons:
    • Even if isExecutable true, Win32 API CreateProcess might not accept it
• b) Always false (My preference)
  • Same as Git -- On (Native-)Windows, it always consider file is not executable
  • Pros:
    • Reflects filesystem attributes precisely -- Windows' filesystem do not have one
  • Cons:
    • Even .exe evaluated as false
• c) Always true
  • Same as Cygwin -- On Cygwin, any files on foreign filesystem is treated as Executable

[lassik]

What's the use case for an isExecutable procedure?

[lassik]

(I once tried writing a procedure to get the filename of the running executable, and faced similar difficulties. The solution was to remove the whole procedure :-)

[okuoku]

What's the use case for an isExecutable procedure?

Mosh(-scheme) has been originally developed to implement Scheme-shell -- if we wanted to implement TAB completion for a command line, we'd need one to pick-up executable from PATH.

On Windows, I think it's for completeness; world's being dominated by POSIX. Even WASI -- which is intended to be write-once-run-anywhere -- have executable bit for now.