Fix Win32 build and stable Linux build #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GWL_USERDATA` is not valid for `GetWindowLongPtr`. Use `GWLP_USERDATA` instead.
Fix stub function
On Win32, `isExecutable` was implemented based on file extension. On Win32, filesystem itself do not have executable bit concept at all.
- Require CMake 3.0 or later - Modernize CMake language - Don't mention MPIR any longer
Fix Linux stable build by adding file extension
higepon
approved these changes
Sep 11, 2022
|
Thanks for the work! |
|
(REOPEN this to perform actual merge.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nitpick to fix Win32 as buildable state, and follow-up #51 .
mosh_stableenvvar but there was mistake on "Build Stable Mosh" step. Previous PR did not catch it because its result was cached.isExecutableimplementation. Filed win32: Consider howisExecutabletreated #65 .