fix: make bitcoin payload serialization deserializable #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicaiahReid
changed the title
MicaiahReid
had a problem deploying
to
Development-mainnet
GitHub Actions
Error
MicaiahReid
had a problem deploying
to
Development-testnet
GitHub Actions
Error
MicaiahReid
requested a deployment
to
Development-mainnet
GitHub Actions
Waiting
MicaiahReid
requested a deployment
to
Development-testnet
GitHub Actions
Waiting
MicaiahReid
added a commit
that referenced
this pull request
May 8, 2024
When a Chainhook is triggered and we send a payload to a user, we filter some values based on user settings (`include_proof`, `include_inputs`, etc). This helps to reduce the payload size that is sent over the wire. However, when we created this payload, we were omitting these fields completely even though the corresponding type does not have those fields as optional. This makes using our SDK types for deserialization impossible. This PR adds in those fields in all cases and sets them to empty values if filtered out.
github-actions bot
pushed a commit
that referenced
this pull request
May 9, 2024
## [1.6.0](v1.5.1...v1.6.0) (2024-05-09) ### Features * add Bitcoin transaction index to typescript client ([#568](#568)) ([6f7eba4](6f7eba4)) ### Bug Fixes * add stacks event position to ts client ([#575](#575)) ([3c48eeb](3c48eeb)) * add starting stacks height for prometheus metrics ([#567](#567)) ([6a8c086](6a8c086)) * make bitcoin payload serialization deserializable ([#569](#569)) ([5f20a86](5f20a86)) * set `Interrupted` status for streaming predicates that fail ([#574](#574)) ([11bde53](11bde53)), closes [#523](#523) * shut down observer on bitcoin block download failure ([#573](#573)) ([f3530b7](f3530b7)), closes [#572](#572)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Chainhook is triggered and we send a payload to a user, we filter some values based on user settings (
include_proof,include_inputs, etc). This helps to reduce the payload size that is sent over the wire.However, when we created this payload, we were omitting these fields completely even though the corresponding type does not have those fields as optional. This makes using our SDK types for deserialization impossible.
This PR adds in those fields in all cases and sets them to empty values if filtered out.