Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add max-amount and auth-id params #1647

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Mar 5, 2024

In stacks-network/stacks-core#4461 we made a few changes to pox-4:

  • A new max-amount and auth-id param to all the functions that take a signer key/sig
  • Added signer-key and all related params to stack-increase

This PR implements those changes

Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 6:22pm

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.49%. Comparing base (115847b) to head (c57ce0b).

Files Patch % Lines
packages/stacking/src/utils.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##           feat/update-stacking-client-to-pox-4    #1647      +/-   ##
========================================================================
+ Coverage                                 66.44%   66.49%   +0.05%     
========================================================================
  Files                                       119      119              
  Lines                                      8740     8755      +15     
  Branches                                   1924     1934      +10     
========================================================================
+ Hits                                       5807     5822      +15     
  Misses                                     2807     2807              
  Partials                                    126      126              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!!

@janniks janniks merged commit 36558cf into hirosystems:feat/update-stacking-client-to-pox-4 Mar 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants