Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set comments and commentstring #3

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pseyfert
Copy link

These variables are documented e.g. here.

For comparison other language plugins also set these two variables vim-go or vim-toml.

I used these variables through the tcomment plugin. e.g. gcc toggles whether the current line is commented in or out.

These variables are documented e.g. [here](https://vimhelp.org/options.txt.html#%27comments%27).

For comparison other language plugins also set these two variables [vim-go](https://github.com/fatih/vim-go/blob/master/ftplugin/go.vim#L22) or [vim-toml](https://github.com/cespare/vim-toml/blob/main/ftplugin/toml.vim#L18).

I used these variables through the [tcomment](https://github.com/tomtom/tcomment_vim) plugin. e.g. `gcc` toggles whether the current line is commented in or out.
@trobro
Copy link
Member

trobro commented Feb 1, 2023

Thanks for the suggestion! But you have only added #, Hjson supports // and /* */ too. They are supported in the default value for comments, along with # followed by a space. So in the current state I assume your PR removes the requirement for a space after #, but drops support for // and /* */?

@pseyfert
Copy link
Author

thanks for spotting. i just added the // and /* */ comments from filetype='cpp' but seems i haven't set them correctly … debugging …

@pseyfert pseyfert marked this pull request as draft February 15, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants