Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage-info): Add storage info endpoint to the admin API client #183

Merged
merged 11 commits into from
Apr 14, 2023
Merged

feat(storage-info): Add storage info endpoint to the admin API client #183

merged 11 commits into from
Apr 14, 2023

Conversation

ThetaSinner
Copy link
Contributor

No description provided.

@ThetaSinner ThetaSinner requested a review from jost-s April 13, 2023 09:40
@ThetaSinner
Copy link
Contributor Author

The test isn't happy because storage_info doesn't exist in the holochain currently pointed to by holonix - still working out what to do about that

@jost-s
Copy link
Contributor

jost-s commented Apr 13, 2023

Until we have a holonix version for 0.2 we can only update the flake to reference develop. I don't want to do that.
I'll run the tests locally too and then we should be good. It's not a potential source of a lot of bugs =)

jost-s
jost-s approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@jost-s jost-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Tested locally with Holochain v0.2.0-beta-rc.4 with success.

It's quite late where you are, so I lower-case the property and merge and release this.

src/api/admin/types.ts
* @public
*/
export interface DnaStorageBlob {
Dna: DnaStorageInfo;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Dna: DnaStorageInfo;
dna: DnaStorageInfo;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be fixed upstream in Holochain. The Conductor API should produce all lower case snake case fields/properties.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed by holochain/holochain#2234

@jost-s
Copy link
Contributor

jost-s commented Apr 14, 2023

Until we have a holonix version for 0.2 we can only update the flake to reference develop. I don't want to do that. I'll run the tests locally too and then we should be good. It's not a potential source of a lot of bugs =)

Actually I pointed the flake to rc.4 after all.

@jost-s jost-s merged commit 28448d1 into main Apr 14, 2023
2 checks passed
@jost-s jost-s deleted the add-storage-info-admin-call branch April 14, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jost-s jost-s jost-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ThetaSinner @jost-s