App ws auth #240
App ws auth #240
Conversation
| @@ -1298,28 +1287,3 @@ test( | |||
| t.equal(response, "hi", "updated coordinator zomes can be called"); | |||
| }) | |||
| ); | |||
|
|
|||
| test( | |||
There was a problem hiding this comment.
Couldn't find a sensible way to retain this. I think if the websocket connection drops then the app needs to reconnect
| @@ -65,7 +65,7 @@ jobs: | |||
| run: nix develop -c $SHELL -c "npm ci" | |||
|
|
|||
| - name: Run tests | |||
| run: nix develop -c $SHELL -c "npm t" | |||
| run: nix develop --override-input versions/holochain "github:holochain/holochain/holochain-0.3.0-beta-dev.48" -c $SHELL -c "npm t" | |||
There was a problem hiding this comment.
Until Holonix is updated we need to test against a specific Holochain that is newer than the one in weekly.
As we work up to automatically testing new releases before releasing Holonix updates, we should find a way to make this simpler than changing the workflow file... Not sure how!
| @@ -32,7 +32,8 @@ | |||
| ], | |||
| "scripts": { | |||
| "lint": "eslint --fix --ext .ts src test .eslintrc.cjs", | |||
| "test:app-agent": "RUST_LOG=error RUST_BACKTRACE=1 tsx test/e2e/app-agent-websocket.ts", | |||
| "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"", | |||
| @@ -19,7 +19,7 @@ export type Requester<Req, Res> = (req: Req, timeout?: number) => Promise<Res>; | |||
| /** | |||
| * @public | |||
| */ | |||
| export type RequesterUnit<Res> = () => Promise<Res>; | |||
| export type RequesterNoArg<Res> = (timeout?: number) => Promise<Res>; | |||
There was a problem hiding this comment.
Is this a rename from Unit (Rust) to NoArg (JS)? Now it has an arg ;-) Anyhow, not that important
There was a problem hiding this comment.
Thanks diff tool! RequesterUnit wasn't used so I deleted it. This one is supposed to be "no request argument"
src/api/app/types.ts
Outdated
| DisableCloneCellRequest, | ||
| DisableCloneCellResponse | ||
| >; | ||
| export interface AppAgentClient { |
There was a problem hiding this comment.
I think we can rename all AppAgent* to App*. WDYT?
There was a problem hiding this comment.
Heck, had moved this stuff without looking too closely - hadn't realised how many instances there were of 'agent' still. On it!
src/api/app/types.ts
Outdated
| /** | ||
| * @public | ||
| */ | ||
| export type AppAgentCallZomeRequest = |
Co-authored-by: Jost Schulte <jost.schulte@protonmail.com>
No description provided.