Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add headless template #267

Merged
merged 27 commits into from May 14, 2024
Merged

Conversation

c12i
Copy link
Collaborator

@c12i c12i commented Apr 19, 2024

Closes #80

@c12i c12i changed the title feat: Add headless template feat: Add ui-less template Apr 19, 2024
@c12i c12i added the ShouldBackport/0.3 This change should be backported to develop-0.3 label May 7, 2024
@c12i c12i self-assigned this May 9, 2024
@c12i c12i requested review from matthme and pdaoust May 10, 2024 15:50
@c12i c12i marked this pull request as ready for review May 12, 2024 22:58
Copy link
Collaborator

@matthme matthme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor change proposals but looks good in general - I'm going to use that in the future, thanks!

templates/headless/web-app.instructions.hbs Show resolved Hide resolved
templates/svelte/web-app/package.json.hbs Show resolved Hide resolved
src/scaffold/web_app/uis.rs Outdated Show resolved Hide resolved
@c12i c12i requested a review from matthme May 13, 2024 14:21
@c12i c12i changed the title feat: Add ui-less template feat: Add headless template May 14, 2024
@c12i c12i merged commit 30bb0da into holochain:develop May 14, 2024
3 of 7 checks passed
c12i added a commit that referenced this pull request May 16, 2024
* fix: invalid entry type fields in vue template (#279)

* fix: prevent unaffected rust files from getting formatted (#281)

* fix: preserve doc comments

* fix: unmodified files getting reformatted by unparse

* refactor map_all_files_rec function

* revert unparse function change

* fix: prevent scaffolding dead code (#280)

* fix: prevent scaffolding dead code

* fix clippy warnings

* improve readability of stringified rust code

* update coordinator functions

* refactor boolean checks

* feat: Add headless template (#267)

* feat: add initial headless template

* include headless template in ui framework choices

* add web-app instructions and prefer explicit hc commands in all package.json templates

* rename instructions template

* fix indentation in instructions

* update instructions

* remove gitkeep

* refactor UiFramework struct

* refactor tempalte config access

* remove assertion

* revert renaming

* revert integrity zome name

* choose non vanilla framework for non hello world examples

* simplify ui framework prompts; update instructions

* update instructions

* Update scripts and instructions

* color code ui frameworks

* templatify web-happ manifest

* fix bug writing invalid template config

* remove unnecessary print statement

* remove unnecessary return statement

* update ui framework try from filetree implementation

* refactor: refactor reserved words check

* update ansi colors for lit and svelte

* Add build happ instruction

* chore: update web-app instructions for headless template

* fix: fix vue example ui server not starting (#284)

* simplify templates_dir

* chore: bump weekly
@c12i c12i removed the ShouldBackport/0.3 This change should be backported to develop-0.3 label May 16, 2024
c12i added a commit to c12i/scaffolding that referenced this pull request May 16, 2024
* feat: add initial headless template

* include headless template in ui framework choices

* add web-app instructions and prefer explicit hc commands in all package.json templates

* rename instructions template

* fix indentation in instructions

* update instructions

* remove gitkeep

* refactor UiFramework struct

* refactor tempalte config access

* remove assertion

* revert renaming

* revert integrity zome name

* choose non vanilla framework for non hello world examples

* simplify ui framework prompts; update instructions

* update instructions

* Update scripts and instructions

* color code ui frameworks

* templatify web-happ manifest

* fix bug writing invalid template config

* remove unnecessary print statement

* remove unnecessary return statement

* update ui framework try from filetree implementation

* refactor: refactor reserved words check

* update ansi colors for lit and svelte

* Add build happ instruction
c12i added a commit that referenced this pull request May 16, 2024
* feat: Add headless template (#267)

* feat: add initial headless template

* include headless template in ui framework choices

* add web-app instructions and prefer explicit hc commands in all package.json templates

* rename instructions template

* fix indentation in instructions

* update instructions

* remove gitkeep

* refactor UiFramework struct

* refactor tempalte config access

* remove assertion

* revert renaming

* revert integrity zome name

* choose non vanilla framework for non hello world examples

* simplify ui framework prompts; update instructions

* update instructions

* Update scripts and instructions

* color code ui frameworks

* templatify web-happ manifest

* fix bug writing invalid template config

* remove unnecessary print statement

* remove unnecessary return statement

* update ui framework try from filetree implementation

* refactor: refactor reserved words check

* update ansi colors for lit and svelte

* Add build happ instruction

* fix: invalid entry type fields in vue template (#279)

* fix: prevent scaffolding dead code (#280)

* fix: prevent scaffolding dead code

* fix clippy warnings

* improve readability of stringified rust code

* update coordinator functions

* refactor boolean checks

* fix: prevent unaffected rust files from getting formatted (#281)

* fix: preserve doc comments

* fix: unmodified files getting reformatted by unparse

* refactor map_all_files_rec function

* revert unparse function change

* fix: fix vue example ui server not starting (#284)

* bump version
c12i added a commit that referenced this pull request May 20, 2024
* fix: invalid entry type fields in vue template (#279)

* fix: prevent unaffected rust files from getting formatted (#281)

* fix: preserve doc comments

* fix: unmodified files getting reformatted by unparse

* refactor map_all_files_rec function

* revert unparse function change

* fix: prevent scaffolding dead code (#280)

* fix: prevent scaffolding dead code

* fix clippy warnings

* improve readability of stringified rust code

* update coordinator functions

* refactor boolean checks

* feat: Add headless template (#267)

* feat: add initial headless template

* include headless template in ui framework choices

* add web-app instructions and prefer explicit hc commands in all package.json templates

* rename instructions template

* fix indentation in instructions

* update instructions

* remove gitkeep

* refactor UiFramework struct

* refactor tempalte config access

* remove assertion

* revert renaming

* revert integrity zome name

* choose non vanilla framework for non hello world examples

* simplify ui framework prompts; update instructions

* update instructions

* Update scripts and instructions

* color code ui frameworks

* templatify web-happ manifest

* fix bug writing invalid template config

* remove unnecessary print statement

* remove unnecessary return statement

* update ui framework try from filetree implementation

* refactor: refactor reserved words check

* update ansi colors for lit and svelte

* Add build happ instruction

* chore: update web-app instructions for headless template

* fix: fix vue example ui server not starting (#284)

* simplify templates_dir

* chore: update manual testing docs (#285)

* chore: update manual testing docs

* update override

* fix: bug while scaffolding collection by author (#290)

* fix: bug while scaffolding collection by author

* fix initial insert statement

* chore: bump weekly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] scaffolding of headless apps
2 participants