New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Button for TotalConnect #114530
Add Button for TotalConnect #114530
Conversation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
dc3f25a
to
2413285
Compare
2413285
to
89e80d2
Compare
89e80d2
to
4f7610b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main idea of adding entity descriptions is making 1 (or several depending on the use case) generic platform class for the integration. After that you can "inject" the entity description via the constructor. Logic can be added via extending the entity description and adding a property that returns a function (I'm sure that press_fn
would return some results). This way, all the entity's property of the different entities are found in one definition, which reduces code duplication and complexity.
Will wait for |
0f5913f
to
8722c4f
Compare
eddfca8
to
062eab4
Compare
5f1c9b6
to
d126247
Compare
Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
Co-authored-by: Jan-Philipp Benecke <github@bnck.me>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
Co-authored-by: Joost Lekkerkerker <joostlek@outlook.com>
This reverts commit 189b7dc.
b6dc351
to
35c76f4
Compare
Proposed change
Adds a bypass button for each zone. Adds a bypass all button and a clear bypass button for each panel/location.
Tests are included.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: