Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Button for TotalConnect #114530

Merged
merged 24 commits into from Apr 29, 2024
Merged

Conversation

austinmroczek
Copy link
Contributor

@austinmroczek austinmroczek commented Mar 31, 2024

Proposed change

Adds a bypass button for each zone. Adds a bypass all button and a clear bypass button for each panel/location.

Tests are included.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [n/a] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

jpbede
jpbede previously requested changes Apr 1, 2024
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/manifest.json Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 1, 2024 22:03
@home-assistant
Copy link

home-assistant bot commented Apr 1, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

Copy link
Member

@joostlek joostlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main idea of adding entity descriptions is making 1 (or several depending on the use case) generic platform class for the integration. After that you can "inject" the entity description via the constructor. Logic can be added via extending the entity description and adding a property that returns a function (I'm sure that press_fn would return some results). This way, all the entity's property of the different entities are found in one definition, which reduces code duplication and complexity.

@home-assistant home-assistant bot marked this pull request as draft April 14, 2024 14:59
@austinmroczek
Copy link
Contributor Author

Will wait for bump PR so tests pass

homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
tests/components/totalconnect/test_button.py Outdated Show resolved Hide resolved
tests/components/totalconnect/test_button.py Outdated Show resolved Hide resolved
tests/components/totalconnect/test_button.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft April 23, 2024 05:43
@austinmroczek austinmroczek force-pushed the tcc_button branch 2 times, most recently from 5f1c9b6 to d126247 Compare April 27, 2024 18:56
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
homeassistant/components/totalconnect/button.py Outdated Show resolved Hide resolved
tests/components/totalconnect/test_button.py Outdated Show resolved Hide resolved
@joostlek joostlek marked this pull request as ready for review April 29, 2024 07:44
@home-assistant home-assistant bot requested a review from joostlek April 29, 2024 07:44
@joostlek joostlek dismissed jpbede’s stale review April 29, 2024 07:44

Changes adressed

@joostlek joostlek merged commit 8153ff7 into home-assistant:dev Apr 29, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants