Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Linear to use a base entity #116133

Merged
merged 4 commits into from Apr 27, 2024

Conversation

IceBotYT
Copy link
Contributor

Proposed change

Separated from #111426
Converts the Linear integration to use a base entity

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@IceBotYT
Copy link
Contributor Author

CI fails because of Codecov rate limit

@IceBotYT IceBotYT marked this pull request as ready for review April 24, 2024 22:03
@home-assistant home-assistant bot marked this pull request as draft April 25, 2024 12:27
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@IceBotYT IceBotYT marked this pull request as ready for review April 27, 2024 18:49
@home-assistant home-assistant bot requested a review from joostlek April 27, 2024 18:49
@IceBotYT
Copy link
Contributor Author

IceBotYT commented Apr 27, 2024

It's so beautiful 🥹
Thank you!

@home-assistant home-assistant bot marked this pull request as draft April 27, 2024 18:55
@IceBotYT IceBotYT marked this pull request as ready for review April 27, 2024 19:58
@home-assistant home-assistant bot requested a review from joostlek April 27, 2024 19:58
@joostlek joostlek merged commit 9fb01f3 into home-assistant:dev Apr 27, 2024
24 checks passed
@IceBotYT IceBotYT deleted the linear-base-entity branch April 27, 2024 21:12
mawoka-myblock pushed a commit to SonnenladenGmbH/core that referenced this pull request Apr 28, 2024
* Convert Linear to use a base entity

* Convert Linear to use a base entity

* Remove str cast in coordinator

* More minor fixes
@github-actions github-actions bot locked and limited conversation to collaborators Apr 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants