Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Sonos connection issues better when polling #51376

Merged

Conversation

jjlawren
Copy link
Contributor

@jjlawren jjlawren commented Jun 2, 2021

Proposed change

I noticed that when falling back to polling, uncaught exceptions can be thrown when speakers are unavailable. This centralizes the exception handling for all platforms.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@jjlawren jjlawren added this to the 2021.6.1 milestone Jun 2, 2021
Dev automation moved this from Needs review to Reviewer approved Jun 3, 2021
@balloob balloob merged commit 2c9e6bd into home-assistant:dev Jun 3, 2021
Dev automation moved this from Reviewer approved to Done Jun 3, 2021
@jjlawren jjlawren deleted the sonos_handle_more_connection_errors branch June 3, 2021 04:11
@balloob balloob mentioned this pull request Jun 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants