Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to iaqualink 0.3.90 #51452

Merged
merged 1 commit into from Jun 4, 2021
Merged

Conversation

flz
Copy link
Contributor

@flz flz commented Jun 3, 2021

Proposed change

Upgrade to iaqualink 0.3.90, fixing URLs after upstream service changes.

Details: https://github.com/flz/iaqualink-py/compare/v0.3.4..v0.3.90

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from Needs review to Reviewer approved Jun 3, 2021
@cgarwood
Copy link
Member

cgarwood commented Jun 4, 2021

should this be tagged for a hotfix release?

@MartinHjelmare MartinHjelmare added this to the 2021.6.2 milestone Jun 4, 2021
@MartinHjelmare MartinHjelmare merged commit 68f6506 into home-assistant:dev Jun 4, 2021
Dev automation moved this from Reviewer approved to Done Jun 4, 2021
balloob pushed a commit that referenced this pull request Jun 4, 2021
@balloob balloob mentioned this pull request Jun 4, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

iAqualink integration no longer works.
5 participants