Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loop in tod binary sensor #51491

Merged
merged 2 commits into from Jun 7, 2021
Merged

Fix loop in tod binary sensor #51491

merged 2 commits into from Jun 7, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 4, 2021

Proposed change

Fix loop in tod binary sensor

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Jun 4, 2021
@bdraco bdraco added this to the 2021.6.3 milestone Jun 4, 2021
@bdraco bdraco marked this pull request as ready for review June 4, 2021 20:57
@bdraco bdraco linked an issue Jun 5, 2021 that may be closed by this pull request
3 tasks
Dev automation moved this from Needs review to Reviewer approved Jun 7, 2021
@bdraco
Copy link
Member Author

bdraco commented Jun 7, 2021

Thanks for the assist @balloob. Back on HST so I'm just starting my day.

@balloob balloob merged commit a3146ad into home-assistant:dev Jun 7, 2021
Dev automation moved this from Reviewer approved to Done Jun 7, 2021
balloob added a commit that referenced this pull request Jun 7, 2021
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
@balloob balloob mentioned this pull request Jun 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants