Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonos battery sensors on S1 firmware #51585

Merged
merged 1 commit into from Jun 7, 2021

Conversation

jjlawren
Copy link
Contributor

@jjlawren jjlawren commented Jun 7, 2021

Proposed change

After a couple attempts, I finally understand how Sonos Move speakers on S1 firmware behave when working with the battery. This should finally resolve #50169.

I was able to reproduce the behavior in the issue above on my S2 speaker by emulating the provided responses.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @cgtobi, mind taking a look at this pull request as its been labeled with an integration (sonos) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Dev automation moved this from Needs review to Reviewer approved Jun 7, 2021
@MartinHjelmare MartinHjelmare merged commit e257dd4 into home-assistant:dev Jun 7, 2021
Dev automation moved this from Reviewer approved to Done Jun 7, 2021
@MartinHjelmare
Copy link
Member

Should this go into a patch release?

@jjlawren
Copy link
Contributor Author

jjlawren commented Jun 7, 2021

Should this go into a patch release?

It can, as long as it applies cleanly to rc.

@jjlawren jjlawren deleted the sonos_fix_s1_battery branch June 7, 2021 22:34
@jjlawren jjlawren added this to the 2021.6.4 milestone Jun 7, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Error in Sonos Integration, battery
5 participants