Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure samsungtv reloads after reauth #51714

Merged
merged 2 commits into from Jun 10, 2021

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jun 10, 2021

Proposed change

The integration would stay unavailable after reauth since there was no reload.

  • Fixes a case of I/O in the event loop

Break out of #51634

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

- Fixes a case of I/O in the event loop
@probot-home-assistant probot-home-assistant bot added integration: samsungtv small-pr PRs with less than 30 lines. labels Jun 10, 2021
@project-bot project-bot bot added this to Needs review in Dev Jun 10, 2021
@bdraco bdraco marked this pull request as draft June 10, 2021 14:56
@bdraco bdraco added this to the 2021.6.4 milestone Jun 10, 2021
@probot-home-assistant
Copy link

Hey there @escoand, @chemelli74, mind taking a look at this pull request as its been labeled with an integration (samsungtv) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco marked this pull request as ready for review June 10, 2021 15:05
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 馃憤

Dev automation moved this from Needs review to Reviewer approved Jun 10, 2021
@frenck frenck merged commit ab490bc into home-assistant:dev Jun 10, 2021
Dev automation moved this from Reviewer approved to Done Jun 10, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants