Fix AccuWeather sensors updates #52031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
has-tests
integration: accuweather
small-pr
balloob
reviewed
Jun 20, 2021
| @@ -182,3 +177,26 @@ def extra_state_attributes(self) -> dict[str, Any]: | |||
| def entity_registry_enabled_default(self) -> bool: | |||
| """Return if the entity should be enabled when first added to the entity registry.""" | |||
| return self._description[ATTR_ENABLED] | |||
|
|
|||
| async def async_added_to_hass(self) -> None: | |||
There was a problem hiding this comment.
This is the default of CoordinatorEntity and shouldn't be needed?
balloob
reviewed
Jun 20, 2021
balloob
reviewed
Jun 20, 2021
balloob
reviewed
Jun 20, 2021
balloob
added a commit
that referenced
this pull request
Jun 21, 2021
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
I made a stupid mistake here and sensor states are not updating.
This PR fixes this and adds a test to avoid such mistakes in the future.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: