Fix returning query results.

PDOStatement::execute() returns a boolean, the statement object contains the results.
horde · Mar 11, 2014 · 37f30ca · 37f30ca
1 parent e68bdd0
commit 37f30ca
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/app/lib/HordeWeb/Utils.php b/app/lib/HordeWeb/Utils.php
@@ -34,7 +34,10 @@ static public function getStableApps()
     {
         $stmt = self::getVersionDb()
             ->prepare('SELECT * FROM versions WHERE state = ?');
-        return $stmt->execute(array('stable'))->fetchAll();
+
+        if ($stmt->execute(array('stable'))) {
+            return $stmt->fetchAll();
+        }
     }
 
     /**
@@ -46,7 +49,10 @@ static public function getH4Apps()
     {
         $stmt = self::getVersionDb()
             ->prepare('SELECT * FROM versions WHERE pear = ?');
-        return $stmt->execute(array(true))->fetchAll();
+
+        if ($stmt->execute(array(true))) {
+            $stmt->fetchAll();
+        }
     }
 
     /**
@@ -58,14 +64,18 @@ static public function getH3Apps()
     {
         $stmt = self::getVersionDb()
             ->prepare('SELECT * FROM versions WHERE state = ?');
-        return $stmt->execute(array('three'))->fetchAll();
+        if ($stmt->execute(array('three'))) {
+            $stmt->fetchAll();
+        }
     }
 
     static public function getDevApps()
     {
         $stmt = self::getVersionDb()
             ->prepare('SELECT * FROM versions WHERE state = ?');
-        return $stmt->execute(array('dev'))->fetchAll();
+        if ($stmt->execute(array('dev'))) {
+            $stmt->fetchAll();
+        }
     }
 
     static public function downloadIcon($view, $app)