Skip to content

Commit

Permalink
Don't pile up modifications in history log.
Browse files Browse the repository at this point in the history
The changes introduced for request #10249 did accumulate all event
modifications in the history log, which eventually lead to bug #13113. Until
Horde_History doesn't scale better for large user numbers, we should not log
even more stuff. Especially if we don't even use this information anywhere.
  • Loading branch information
yunosh committed Apr 16, 2014
1 parent 0ede15e commit 122e6df
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions kronolith/lib/Driver/Sql.php
Expand Up @@ -632,7 +632,7 @@ protected function _updateEvent(Kronolith_Event $event)
/* Log the modification of this item in the history log. */
if ($event->uid) {
try {
$GLOBALS['injector']->getInstance('Horde_History')->log('kronolith:' . $this->calendar . ':' . $event->uid, $history, false);
$GLOBALS['injector']->getInstance('Horde_History')->log('kronolith:' . $this->calendar . ':' . $event->uid, $history, true);
} catch (Exception $e) {
Horde::log($e, 'ERR');
}
Expand All @@ -643,7 +643,7 @@ protected function _updateEvent(Kronolith_Event $event)
* change. */
if ($event->baseid) {
try {
$GLOBALS['injector']->getInstance('Horde_History')->log('kronolith:' . $this->calendar . ':' . $event->baseid, $history, false);
$GLOBALS['injector']->getInstance('Horde_History')->log('kronolith:' . $this->calendar . ':' . $event->baseid, $history, true);
} catch (Exception $e) {
Horde::log($e, 'ERR');
}
Expand Down

0 comments on commit 122e6df

Please sign in to comment.