check if relationship is empty (LEFT JOIN)

if there was a relationship added using a left join the fields of the joined table may be empty
horde · Jul 21, 2016 · 16821cf · 16821cf
1 parent 676f9e0
commit 16821cf
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/framework/Rdo/lib/Horde/Rdo/Mapper.php b/framework/Rdo/lib/Horde/Rdo/Mapper.php
@@ -253,7 +253,9 @@ public function mapFields($object, $fields = array())
                     }
                 }
 
-                if (isset($relationships[$m->table])) {
+                // don't only check the table, if there was a match
+                // for LEFT JOINs there may be a "empty" result
+                if (isset($relationships[$m->table], $relationships[$m->table][$m->primaryKey])) {
                     $object->$relationship = $m->map($relationships[$m->table]);
                 }
             }