Add addChangedFlag()

This should be run by display code (not library code), and only by code that uses it (this is not used on message page).
horde · Jan 15, 2015 · 180045a · 180045a
1 parent 3ecf6d8
commit 180045a
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 6 deletions.
diff --git a/imp/lib/Ajax/Queue.php b/imp/lib/Ajax/Queue.php
@@ -456,6 +456,8 @@ public function message(IMP_Indices $indices, array $opts = array())
             $show_msg = new IMP_Contents_Message($indices, !empty($opts['peek']));
             $msg = (object)$show_msg->showMessage();
 
+            $show_msg->addChangedFlag();
+
             /* Need to grab cached inline scripts. */
             Horde::startBuffer();
             $page_output->outputInlineScript(true);

diff --git a/imp/lib/Contents/Message.php b/imp/lib/Contents/Message.php
@@ -178,8 +178,6 @@ public function showMessage()
         $part_info = $this->part_info;
         $show_parts = $prefs->getValue('parts_display');
 
-        list($mbox,) = $this->_indices->getSingle();
-
         /* Do MDN processing now. */
         switch ($registry->getView()) {
         case $registry::VIEW_DYNAMIC:
@@ -262,15 +260,32 @@ public function showMessage()
             )
         )->setRaw(true);
 
+        return $result;
+    }
+
+    /**
+     * Add changed flag information to the AJAX queue output, if necessary.
+     */
+    public function addChangedFlag()
+    {
+        global $injector;
+
         /* Add changed flag information. */
+        list($mbox,) = $this->_indices->getSingle();
         if (!$this->_peek && $mbox->is_imap) {
-            $status = $mbox->imp_imap->status($mbox, Horde_Imap_Client::STATUS_PERMFLAGS);
+            $status = $mbox->imp_imap->status(
+                $mbox,
+                Horde_Imap_Client::STATUS_PERMFLAGS
+            );
+
             if (in_array(Horde_Imap_Client::FLAG_SEEN, $status['permflags'])) {
-                $ajax_queue->flag(array(Horde_Imap_Client::FLAG_SEEN), true, $this->_indices);
+                $injector->getInstance('IMP_Ajax_Queue')->flag(
+                    array(Horde_Imap_Client::FLAG_SEEN),
+                    true,
+                    $this->_indices
+                );
             }
         }
-
-        return $result;
     }
 
     /**