Skip to content

Commit

Permalink
Providing full classname results in slightly faster loading
Browse files Browse the repository at this point in the history
  • Loading branch information
slusarz committed Jan 25, 2014
1 parent 775abcd commit 182c46b
Show file tree
Hide file tree
Showing 14 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion framework/Core/lib/Horde.php
Expand Up @@ -1191,7 +1191,7 @@ static public function getCacheUrl($type, $params = array())
*/
static public function popupJs($url, $options = array())
{
$GLOBALS['page_output']->addScriptPackage('Popup');
$GLOBALS['page_output']->addScriptPackage('Horde_Core_Script_Package_Popup');

$params = new stdClass;

Expand Down
2 changes: 1 addition & 1 deletion framework/Core/lib/Horde/Core/Ajax/Imple/AutoCompleter.php
Expand Up @@ -30,7 +30,7 @@ protected function _attach($init)
if (!self::$_initAc) {
$page_output->addScriptFile('autocomplete.js', 'horde');
$page_output->addScriptFile('liquidmetal.js', 'horde');
$page_output->addScriptPackage('Keynavlist');
$page_output->addScriptPackage('Horde_Core_Script_Package_Keynavlist');

$page_output->addInlineJsVars(array(
'HordeImple.AutoCompleter' => new stdClass
Expand Down
2 changes: 1 addition & 1 deletion framework/Core/lib/Horde/Core/Ajax/Imple/SpellChecker.php
Expand Up @@ -52,7 +52,7 @@ protected function _attach($init)

if ($init) {
$page_output->addScriptFile('spellchecker.js', 'horde');
$page_output->addScriptPackage('Keynavlist');
$page_output->addScriptPackage('Horde_Core_Script_Package_Keynavlist');

$page_output->addInlineJsVars(array(
'HordeImple.SpellChecker' => new stdClass
Expand Down
2 changes: 1 addition & 1 deletion framework/Core/lib/Horde/PageOutput.php
Expand Up @@ -725,7 +725,7 @@ public function header(array $opts = array())
$this->growler = true;

$this->_addBasicScripts();
$this->addScriptPackage('Popup');
$this->addScriptPackage('Horde_Core_Script_Package_Popup');
break;

case $registry::VIEW_MINIMAL:
Expand Down
2 changes: 1 addition & 1 deletion gollem/manager.php
Expand Up @@ -594,7 +594,7 @@
$template->itemcount = sprintf(ngettext(_("%d item"), _("%d items"), $total), $total);

$page_output->addScriptFile('manager.js');
$page_output->addScriptPackage('Dialog');
$page_output->addScriptPackage('Horde_Core_Script_Package_Dialog');
$page_output->addInlineJsVars(array(
'var GollemVar' => array(
'actionUrl' => strval(Horde::url('manager.php')),
Expand Down
2 changes: 1 addition & 1 deletion hermes/lib/Ajax.php
Expand Up @@ -22,7 +22,7 @@ public function init()

$page_output->addScriptFile('redbox.js', 'horde');
$page_output->addScriptFile('tooltips.js', 'horde');
$page_output->addScriptPackage('Datejs');
$page_output->addScriptPackage('Horde_Core_Script_Package_Datejs');
$page_output->addScriptFile('quickfinder.js', 'horde');
if ($GLOBALS['browser']->isBrowser('msie')) {
$page_output->addScriptFile('excanvas/excanvas.min.js', 'horde');
Expand Down
2 changes: 1 addition & 1 deletion horde/lib/View/Topbar.php
Expand Up @@ -83,7 +83,7 @@ public function __construct($config = array())
/* Sub bar. */
$this->date = strftime($prefs->getValue('date_format'));
$pageOutput = $injector->getInstance('Horde_PageOutput');
$pageOutput->addScriptPackage('Datejs');
$pageOutput->addScriptPackage('Horde_Core_Script_Package_Datejs');
$pageOutput->addScriptFile('topbar.js', 'horde');
$pageOutput->addInlineJsVars(array('HordeTopbar.conf' => array(
/* Need explicit URI here, since topbar may be running in
Expand Down
2 changes: 1 addition & 1 deletion imp/lib/Ajax/Imple/PassphraseDialog.php
Expand Up @@ -42,7 +42,7 @@ protected function _attach($init)
global $page_output;

if ($init) {
$page_output->addScriptPackage('Dialog');
$page_output->addScriptPackage('Horde_Core_Script_Package_Dialog');
$page_output->addScriptFile('passphrase.js', 'imp');
}

Expand Down
2 changes: 1 addition & 1 deletion imp/lib/Basic/Mailbox.php
Expand Up @@ -400,7 +400,7 @@ protected function _init()

$page_output->addScriptFile('hordecore.js', 'horde');
$page_output->addScriptFile('mailbox.js');
$page_output->addScriptPackage('Dialog');
$page_output->addScriptPackage('Horde_Core_Script_Package_Dialog');

$page_output->metaRefresh($prefs->getValue('refresh_time'), $refresh_url);

Expand Down
2 changes: 1 addition & 1 deletion imp/lib/Basic/Message.php
Expand Up @@ -898,7 +898,7 @@ protected function _init()

if (!empty($conf['tasklist']['use_notepad']) ||
!empty($conf['tasklist']['use_tasklist'])) {
$page_output->addScriptPackage('Dialog');
$page_output->addScriptPackage('Horde_Core_Script_Package_Dialog');
}

$page_output->noDnsPrefetch();
Expand Down
4 changes: 2 additions & 2 deletions imp/lib/Dynamic/Compose/Common.php
Expand Up @@ -38,15 +38,15 @@ public function compose(IMP_Dynamic_Base $base, array $args = array())
{
global $injector, $page_output, $prefs;

$page_output->addScriptPackage('Keynavlist');
$page_output->addScriptPackage('Horde_Core_Script_Package_Keynavlist');
$page_output->addScriptPackage('IMP_Script_Package_ComposeBase');
$page_output->addScriptFile('compose-dimp.js');
$page_output->addScriptFile('draghandler.js');
$page_output->addScriptFile('external/murmurhash3.js');

if (!$prefs->isLocked('default_encrypt') &&
($prefs->getValue('use_pgp') || $prefs->getValue('use_smime'))) {
$page_output->addScriptPackage('Dialog');
$page_output->addScriptPackage('Horde_Core_Script_Package_Dialog');
$page_output->addScriptFile('passphrase.js');
}

Expand Down
2 changes: 1 addition & 1 deletion imp/lib/Dynamic/Mailbox.php
Expand Up @@ -36,7 +36,7 @@ protected function _init()
$page_output->addScriptFile('jstorage.js', 'horde');
$page_output->addScriptFile('slider2.js', 'horde');
$page_output->addScriptFile('toggle_quotes.js', 'horde');
$page_output->addScriptPackage('Dialog');
$page_output->addScriptPackage('Horde_Core_Script_Package_Dialog');
$page_output->addScriptPackage('IMP_Script_Package_Imp');

$imp_imap = $injector->getInstance('IMP_Factory_Imap')->create();
Expand Down
2 changes: 1 addition & 1 deletion kronolith/lib/Ajax.php
Expand Up @@ -24,7 +24,7 @@ public function init()
$page_output->addScriptFile('redbox.js', 'horde');
$page_output->addScriptFile('tooltips.js', 'horde');
$page_output->addScriptFile('colorpicker.js', 'horde');
$page_output->addScriptPackage('Datejs');
$page_output->addScriptPackage('Horde_Core_Script_Package_Datejs');
$page_output->addScriptFile('kronolith.js');
Horde_Core_Ui_JsCalendar::init(array('short_weekdays' => true));

Expand Down
2 changes: 1 addition & 1 deletion nag/task.php
Expand Up @@ -134,7 +134,7 @@ function _delete($task_id, $tasklist_id)
$GLOBALS['page_output']->addScriptFile('date/' . $datejs, 'horde');
$GLOBALS['page_output']->addScriptFile('date/date.js', 'horde');
$GLOBALS['page_output']->addScriptFile('task.js');
$GLOBALS['page_output']->addScriptPackage('Keynavlist');
$GLOBALS['page_output']->addScriptPackage('Horde_Core_Script_Package_Keynavlist');

$GLOBALS['page_output']->header(array(
'title' => $form->getTitle()
Expand Down

0 comments on commit 182c46b

Please sign in to comment.