Skip to content

Commit

Permalink
Bug: 13905 Compare attendees in case-insensitive manner.
Browse files Browse the repository at this point in the history
  • Loading branch information
@mrubinsk
mrubinsk committed Mar 13, 2015
1 parent f4afa3a commit 185ae67
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kronolith/lib/Event.php
View file
Expand Up @@ -2691,7 +2691,7 @@ public function getLocation($user = null)
*/
public function hasAttendee($email)
{
return isset($this->attendees[$email]);
return isset($this->attendees[Horde_String::lower($email)]);
}

/**
Expand Down

6 comments on commit 185ae67

@yunosh
Copy link
Member

@yunosh yunosh commented on 185ae67 Mar 13, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to make a more elaborated check, because technically the user part is case sensitive. I bet MMS has some library for that ;-)

@slusarz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Horde_Mail_Rfc822_Address@matchInsensitive().

Although it would require a bit of refactoring to work in this case since the matching emails are being stored as strings in a hashed array - although I will point out that this only works if the email in the key has previously been stored lowercase (which it shouldn't).

@mrubinsk
Copy link
Member Author

@mrubinsk mrubinsk commented on 185ae67 Mar 13, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrubinsk
Copy link
Member Author

@mrubinsk mrubinsk commented on 185ae67 Mar 13, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slusarz
Copy link
Member

@slusarz slusarz commented on 185ae67 Mar 13, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrubinsk
Copy link
Member Author

@mrubinsk mrubinsk commented on 185ae67 Mar 13, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.