Skip to content

Commit

Permalink
Remove non-functional Facebook posting.
Browse files Browse the repository at this point in the history
FB has removed to read_stream permissions and requires post_actions
permissions to do this - but only after FB has individually reviewed
the application and has approved the use.
So, every Horde install would need an independent
review.

They have also removed the read_stream permission so only a
subset of posts (maybe only public pages??) are currently
displayed. This should probably just be dropped completely...
  • Loading branch information
mrubinsk committed Mar 11, 2016
1 parent 3c389f0 commit 232c383
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 12 deletions.
1 change: 0 additions & 1 deletion horde/js/facebookclient.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ var Horde_Facebook = Class.create({

this.getNewEntries();
$(this.opts.getmore).observe('click', function(e) { this.getOlderEntries(); e.stop(); }.bind(this));
$(this.opts.button).observe('click', function(e) { this.updateStatus(); e.stop(); }.bind(this));
},

/**
Expand Down
20 changes: 9 additions & 11 deletions horde/lib/Block/FbStream.php
Original file line number Diff line number Diff line change
Expand Up @@ -128,17 +128,15 @@ protected function _content()
$html .= '<div style="padding: 8px 8px 0 8px">';

try {
$fbperms = $facebook->users->getAppPermissions();
if (!empty($fbperms[Horde_Service_Facebook_Auth::EXTEND_PERMS_PUBLISHSTREAM])) {
$html .= '<input style="width:98%;margin-top:4px;margin-bottom:4px;" type="text" class="fbinput" id="' . $instance . '_newStatus" name="newStatus" />'
. '<div><a class="horde-default" href="#" id="' . $instance . '_button">' . _("Post") . '</a></div>'
. Horde_Themes_Image::tag('loading.gif', array(
'attr' => array(
'id' => $instance. '_loading',
'style' => 'display:none;'
)
));
}
$html .= Horde_Themes_Image::tag(
'loading.gif',
array(
'attr' => array(
'id' => $instance. '_loading',
'style' => 'display:none;'
)
)
);
} catch (Horde_Service_Facebook_Exception $e) {
$prefs = $GLOBALS['registry']->getServiceLink('prefs');
$html .= sprintf(_("There was an error making the request: %s"), $e->getMessage());
Expand Down

0 comments on commit 232c383

Please sign in to comment.