Ensure $length is always a valid value.

horde · Sep 21, 2015 · 253a4de · 253a4de
1 parent 092830a
commit 253a4de
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/framework/Service_Weather/lib/Horde/Service/Weather/WeatherUnderground.php b/framework/Service_Weather/lib/Horde/Service/Weather/WeatherUnderground.php
@@ -233,8 +233,9 @@ protected function _searchLocations($location)
      * a bit of request time/traffic for a smaller number of requests to obtain
      * information for e.g., a typical weather portal display.
      */
-    protected function _getCommonElements($location, $length = Horde_Service_Weather::FORECAST_10DAY)
+    protected function _getCommonElements($location, $length = null)
     {
+        $length = empty($length) ? Horde_Service_Weather::FORECAST_10DAY : $length;
         if (!empty($this->_forecast) && $location == $this->_lastLocation
             && $this->_lastLength >= $length) {