[mms] Workaround broken SASL capability responses from POP3 servers.

horde · Feb 27, 2014 · 3bdd058 · 3bdd058
1 parent 36eb2ab
commit 3bdd058
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/framework/Imap_Client/lib/Horde/Imap/Client/Socket/Pop3.php b/framework/Imap_Client/lib/Horde/Imap/Client/Socket/Pop3.php
@@ -219,7 +219,9 @@ protected function _login()
         }
 
         if (empty($this->_init['authmethod'])) {
-            $auth_mech = ($sasl = $this->queryCapability('SASL'))
+            /* Sanity checking: at least one server (Dovecot 1.x) may return
+             * SASL response with no arguments. */
+            $auth_mech = (($sasl = $this->queryCapability('SASL')) && is_array($sasl))
                 ? $sasl
                 : array();
 

diff --git a/framework/Imap_Client/package.xml b/framework/Imap_Client/package.xml
@@ -21,6 +21,7 @@
  </stability>
  <license uri="http://www.horde.org/licenses/lgpl21">LGPL-2.1</license>
  <notes>
+* [mms] Workaround broken SASL capability responses from POP3 servers.
 * [mms] Prevent PHP error when a FETCH call is unsuccessful.
 * [mms] Relax type checking on cache driver object.
  </notes>
@@ -2214,6 +2215,7 @@
    <date>2014-02-24</date>
    <license uri="http://www.horde.org/licenses/lgpl21">LGPL-2.1</license>
    <notes>
+* [mms] Workaround broken SASL capability responses from POP3 servers.
 * [mms] Prevent PHP error when a FETCH call is unsuccessful.
 * [mms] Relax type checking on cache driver object.
    </notes>