Skip to content

Commit

Permalink
Don't overwrite $rows.
Browse files Browse the repository at this point in the history
  • Loading branch information
yunosh committed Aug 12, 2016
1 parent 4fe872a commit 3beb82b
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions framework/Queue/lib/Horde/Queue/Storage/Db.php
Expand Up @@ -64,9 +64,10 @@ public function getMany($num = 50)
$query = 'DELETE FROM horde_queue_tasks WHERE task_id = ?';
foreach ($rows as $row) {
$tasks[] = unserialize($row['task_fields']);
// TODO: Evaluate if a single call for all IDs is faster for various scenarios
// TODO: Evaluate if a single call for all IDs is faster for
// various scenarios
try {
$rows = $this->_db->execute($query, array($row['task_id']));
$this->_db->execute($query, array($row['task_id']));
} catch (Horde_Db_Exception $e) {
throw new Horde_Queue_Exception($e);
}
Expand Down

0 comments on commit 3beb82b

Please sign in to comment.