Skip to content

Commit

Permalink
I don't see any place where we still suffix the share ID with an owne…
Browse files Browse the repository at this point in the history
…r ID.

But spliting twice on colons breaks groups with contacts that contain colons in
their ID, e.g. with some LDAP setups.
  • Loading branch information
yunosh committed Aug 4, 2014
1 parent 03dec20 commit 5235615
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions turba/lib/Object/Group.php
Original file line number Diff line number Diff line change
Expand Up @@ -167,17 +167,11 @@ public function listMembers($sort = null)
}
} else {
list($sourceId, $contactId) = explode(':', $member, 2);
if (strpos($contactId, ':')) {
list($owner, $contactId) = explode(':', $contactId, 2);
$sourceId .= ':' . $owner;
}

try {
$driver = $GLOBALS['injector']->getInstance('Turba_Factory_Driver')->create($sourceId);
} catch (Turba_Exception $e) {
continue;
}

try {
$contact = $driver->getObject($contactId);
} catch (Horde_Exception_NotFound $e) {
Expand Down

0 comments on commit 5235615

Please sign in to comment.