[mms] Fix regression in reporting capabilities (Bug #13421).

horde · Aug 6, 2014 · 533cba5 · 533cba5
1 parent c89a95c
commit 533cba5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/framework/Imap_Client/lib/Horde/Imap/Client/Data/Capability.php b/framework/Imap_Client/lib/Horde/Imap/Client/Data/Capability.php
@@ -116,9 +116,9 @@ public function query($capability, $parameter = null)
             return false;
         }
 
-        return (is_null($parameter) || !is_array($this->_data[$capability]))
-            ? true
-            : in_array(strtoupper($parameter), $this->_data[$capability]);
+        return is_null($parameter) ?:
+               (is_array($this->_data[$capability]) &&
+                in_array(strtoupper($parameter), $this->_data[$capability]));
     }
 
     /**

diff --git a/framework/Imap_Client/package.xml b/framework/Imap_Client/package.xml
@@ -21,7 +21,7 @@
  </stability>
  <license uri="http://www.horde.org/licenses/lgpl21">LGPL-2.1</license>
  <notes>
-* 
+* [mms] Fix regression in reporting capabilities (Bug #13421).
  </notes>
  <contents>
   <dir baseinstalldir="/" name="/">
@@ -2578,7 +2578,7 @@
    <date>2014-08-04</date>
    <license uri="http://www.horde.org/licenses/lgpl21">LGPL-2.1</license>
    <notes>
-* 
+* [mms] Fix regression in reporting capabilities (Bug #13421).
    </notes>
   </release>
  </changelog>

diff --git a/framework/Imap_Client/test/Horde/Imap/Client/Data/CapabilityTest.php b/framework/Imap_Client/test/Horde/Imap/Client/Data/CapabilityTest.php
@@ -35,6 +35,7 @@ public function testQuery()
         $this->assertTrue($c->query('foo'));
 
         $this->assertFalse($c->query('BAR'));
+        $this->assertFalse($c->query('FOO', 'BAR'));
 
         $c->add('bar');