Invalidate the IMAP object if the password cannot be recreated from s…

…ession data
horde · Dec 15, 2014 · 56c03a6 · 56c03a6
1 parent ef4a59e
commit 56c03a6
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/imp/lib/Imap/Password.php b/imp/lib/Imap/Password.php
@@ -77,11 +77,23 @@ public function serialize()
     }
 
     /**
+     * @throws RuntimeException
      */
     public function unserialize($data)
     {
         $this->_id = $data;
-        $this->_password = $GLOBALS['session']->get('imp', self::PASSWORD_KEY . '/' . $this->_id);
+
+        $password = $GLOBALS['session']->get(
+            'imp',
+            self::PASSWORD_KEY . '/' . $this->_id
+        );
+        if (!strlen($password)) {
+            /* Without a password, this object is invalid. */
+            throw new RuntimeException(
+                'Invalid object since password is empty.'
+            );
+        }
+        $this->_password = $password;
     }
 
 }