[mms] SECURITY: Fix XSS in displaying user-defined flags in dynamic m…

…ailbox view (João Machado <geral@jpaulo.eu>).
horde · Mar 18, 2014 · 578ff07 · 578ff07
1 parent 6774485
commit 578ff07
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/imp/docs/CHANGES b/imp/docs/CHANGES
@@ -2,6 +2,8 @@
 v6.1.8-git
 ----------
 
+[mms] SECURITY: Fix XSS in displaying user-defined flags in dynamic mailbox
+      view (João Machado <geral@jpaulo.eu>).
 [mms] SECURITY: Fix XSS in displaying mailbox name in dynamic mailbox view
       (João Machado <geral@jpaulo.eu>).
 

diff --git a/imp/js/dimpbase.js b/imp/js/dimpbase.js
@@ -477,7 +477,7 @@ var DimpBase = {
                                 /* Until text-overflow is supported on all
                                  * browsers, need to truncate label text
                                  * ourselves. */
-                                ptr.elt = '<span class="' + ptr.c + '" title="' + ptr.l.escapeHTML() + '" style="background:' + ((ptr.b) ? ptr.b.escapeHTML() : '') + ';color:' + ptr.f.escapeHTML() + '">' + ptr.l.truncate(10).escapeHTML() + '</span>';
+                                ptr.elt = '<span class="' + ptr.c + '" title="' + ptr.l.escapeHTML().gsub('"', '&quot;') + '" style="background:' + ((ptr.b) ? ptr.b.escapeHTML().gsub('"', '&quot;') : '') + ';color:' + ptr.f.escapeHTML().gsub('"', '&quot') + '">' + ptr.l.truncate(10).escapeHTML() + '</span>';
                             }
                             r.subjectdata += ptr.elt;
                         } else {

diff --git a/imp/package.xml b/imp/package.xml
@@ -33,6 +33,7 @@
  </stability>
  <license uri="http://www.horde.org/licenses/gpl">GPL-2.0</license>
  <notes>
+* [mms] SECURITY: Fix XSS in displaying user-defined flags in dynamic mailbox view (João Machado &lt;geral@jpaulo.eu&gt;).
 * [mms] SECURITY: Fix XSS in displaying mailbox name in dynamic mailbox view (João Machado &lt;geral@jpaulo.eu&gt;).
  </notes>
  <contents>
@@ -3343,6 +3344,7 @@
    <date>2014-03-07</date>
    <license uri="http://www.horde.org/licenses/gpl">GPL-2.0</license>
    <notes>
+* [mms] SECURITY: Fix XSS in displaying user-defined flags in dynamic mailbox view (João Machado &lt;geral@jpaulo.eu&gt;).
 * [mms] SECURITY: Fix XSS in displaying mailbox name in dynamic mailbox view (João Machado &lt;geral@jpaulo.eu&gt;).
    </notes>
   </release>