Skip to content

Commit

Permalink
[mms] Fix Horde_Prefs#isDefault() to return true if the given pref na…
Browse files Browse the repository at this point in the history
…me doesn't exist in a scope.

Since the pref is not defined, whatever value given should be considered
the default.

Ticket #13732
  • Loading branch information
slusarz committed Dec 3, 2014
1 parent 20c98f3 commit 690d731
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion framework/Prefs/lib/Horde/Prefs.php
Expand Up @@ -330,7 +330,7 @@ public function isDefault($pref)
{
return ($scope = $this->_getScope($pref))
? $this->_scopes[$scope]->isDefault($pref)
: false;
: true;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions framework/Prefs/package.xml
Expand Up @@ -33,7 +33,7 @@
</stability>
<license uri="http://www.horde.org/licenses/lgpl21">LGPL-2.1</license>
<notes>
*
* [mms] Fix Horde_Prefs#isDefault() to return true if the given pref name doesn&apos;t exist in a scope.
</notes>
<contents>
<dir baseinstalldir="/" name="/">
Expand Down Expand Up @@ -1130,7 +1130,7 @@ Initial release as a PEAR package
<date>2014-10-21</date>
<license uri="http://www.horde.org/licenses/lgpl21">LGPL-2.1</license>
<notes>
*
* [mms] Fix Horde_Prefs#isDefault() to return true if the given pref name doesn&apos;t exist in a scope.
</notes>
</release>
</changelog>
Expand Down

0 comments on commit 690d731

Please sign in to comment.