Skip to content

Commit

Permalink
[jan] Fix broken offsets during first zone rules.
Browse files Browse the repository at this point in the history
  • Loading branch information
yunosh committed Oct 18, 2013
1 parent 003fc41 commit 7d85279
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 2 additions & 1 deletion framework/Timezone/lib/Horde/Timezone/Zone.php
Expand Up @@ -105,7 +105,9 @@ public function toVtimezone()
$component = new Horde_Icalendar_Daylight();
} else {
// Represented by a ruleset.
$startOffset = $this->_getOffset($i);
$this->_tz->getRule($this->_info[$i][1])->addRules($tz, $this->_name, $name, $startOffset, $startDate, $endDate);
$startDate = $endDate;
// Continue, because addRules() already adds the
// component to $tz.
continue;
Expand All @@ -115,7 +117,6 @@ public function toVtimezone()
$startOffset = $this->_getOffset($i);
$component->setAttribute('TZOFFSETTO', $startOffset);
$component->setAttribute('TZNAME', $name);
$startDate = $endDate;
$tz->addComponent($component);
}

Expand Down
2 changes: 2 additions & 0 deletions framework/Timezone/package.xml
Expand Up @@ -22,6 +22,7 @@
</stability>
<license uri="http://www.horde.org/licenses/lgpl21">LGPL-2.1</license>
<notes>
* [jan] Fix broken offsets during first zone rules.
* [jan] Make BYMONTHDAY property as short as possible.
* [jan] Fix missing time of day in DTSTART and UNTIL properties.
* [jan] Don&apos;t create transitions that overlap.
Expand Down Expand Up @@ -199,6 +200,7 @@
<date>2013-05-06</date>
<license uri="http://www.horde.org/licenses/lgpl21">LGPL-2.1</license>
<notes>
* [jan] Fix broken offsets during first zone rules.
* [jan] Make BYMONTHDAY property as short as possible.
* [jan] Fix missing time of day in DTSTART and UNTIL properties.
* [jan] Don&apos;t create transitions that overlap.
Expand Down

0 comments on commit 7d85279

Please sign in to comment.