Skip to content

Commit

Permalink
Fix parsing tags
Browse files Browse the repository at this point in the history
Due to changes in 5669cb7, this is now
correctly being parsed as XML, not HTML.  As such, attribute names are
case-sensitive, so it is htmlUrl and xmlUrl, not htmlurl and xmlurl.
  • Loading branch information
slusarz committed Apr 17, 2014
1 parent 201114d commit 9044a6e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion framework/Feed/lib/Horde/Feed/Blogroll.php
Expand Up @@ -48,7 +48,7 @@ protected function _buildListItemCache()
{
$entries = array();
foreach ($this->_element->getElementsByTagName('outline') as $child) {
if ($child->attributes->getNamedItem('xmlurl')) {
if ($child->attributes->getNamedItem('xmlUrl')) {
$entries[] = $child;
}
}
Expand Down
6 changes: 3 additions & 3 deletions framework/Feed/test/Horde/Feed/BlogrollTest.php
Expand Up @@ -27,13 +27,13 @@ public function testValidBlogrolls($file)

$this->assertInstanceOf('Horde_Feed_Entry_Blogroll', $entry);
$this->assertGreaterThan(0, strlen($entry->text));
$this->assertGreaterThan(0, strlen($entry->xmlurl));
$this->assertGreaterThan(0, strlen($entry->xmlUrl));

$this->assertEquals($entry->text, $entry['text']);
$this->assertEquals($entry->description, $entry['description']);
$this->assertEquals($entry->title, $entry['title']);
$this->assertEquals($entry->htmlurl, $entry['htmlurl']);
$this->assertEquals($entry->xmlurl, $entry['xmlurl']);
$this->assertEquals($entry->htmlUrl, $entry['htmlUrl']);
$this->assertEquals($entry->xmlUrl, $entry['xmlUrl']);
}

public function testGroupedBlogrolls()
Expand Down

0 comments on commit 9044a6e

Please sign in to comment.