Proper fix for Bug: 13308

horde · Jul 1, 2014 · 9bf765f · 9bf765f
1 parent c49b3f7
commit 9bf765f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/nag/app/controllers/SaveTask.php b/nag/app/controllers/SaveTask.php
@@ -102,7 +102,8 @@ public function processRequest(Horde_Controller_Request $request, Horde_Controll
                 'tasklist_id' => $info['tasklist_id'],
                 'parent' => $info['parent']));
         } else {
-            $url = Horde_Util::getFormData('url', Horde::url('list.php', true));
+            $url = Horde_Util::getFormData('url', (string)Horde::url('list.php', true));
+            $url = Horde::url($url, true);
         }
 
         $response->setRedirectUrl($url);

diff --git a/nag/task.php b/nag/task.php
@@ -106,6 +106,9 @@ function _delete($task_id, $tasklist_id)
             $vars = new Horde_Variables($h);
             $vars->set('old_tasklist', $task->tasklist);
             $vars->set('url', Horde_Util::getFormData('url'));
+            if ($u = Horde_Util::getFormData('url')) {
+                $vars->set('url', $u);
+            }
             $form = new Nag_Form_Task($vars, sprintf(_("Edit: %s"), $task->name));
             break;
         }

diff --git a/nag/templates/list.html.php b/nag/templates/list.html.php
@@ -63,8 +63,7 @@ function doPrefsUpdate(column, sortDown)
               'due' => $due,
               'columns' => $this->columns,
               'dynamic_sort' => $this->dynamic_sort &= !$task->hasSubTasks(),
-              'dateFormat' => $GLOBALS['prefs']->getValue('date_format'),
-              'haveSearch' => $this->haveSearch); ?>
+              'dateFormat' => $GLOBALS['prefs']->getValue('date_format')); ?>
             <?php echo $this->renderPartial('list/task', array('locals' => $locals)) ?>
         <?php endwhile; ?>
       </tbody>

diff --git a/nag/templates/list/_task.html.php b/nag/templates/list/_task.html.php
@@ -35,7 +35,8 @@
     if ($have_edit &&
         (!$task->private || $task->owner == $GLOBALS['registry']->getAuth())) {
         $label = sprintf(_("Edit \"%s\""), $task->name);
-        echo Horde::link($task->edit_link->add('have_search', $this->haveSearch), $label) . Horde::img('edit.png', $label) . '</a>';
+        $params = array('have_search' => $this->haveSearch, 'url' => Horde::selfUrl(true));
+        echo Horde::link($task->edit_link->add($params), $label) . Horde::img('edit.png', $label) . '</a>';
     }
     ?>
   </td>