Revert "[mms] Rate-limit filters drag/drop changes to prevent race co…

…nditions (Bug #13819)." This reverts commit c521c26. Not needed anymore - race-conditions have been fixed by accessing rules by UIDs instead of filter position
horde · Feb 24, 2015 · af9d504 · af9d504
1 parent 7416f09
commit af9d504
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 38 deletions.
diff --git a/ingo/docs/CHANGES b/ingo/docs/CHANGES
@@ -11,8 +11,6 @@ v3.3.0-git
 v3.2.4
 ------
 
-[mms] Rate-limit filters drag/drop changes to prevent race conditions (Bug
-      #13819).
 [mms] Fix filter drag/drop ordering working in basic view (Bug #13820).
 [mms] Maildir requires UTF7-IMAP encoding for folder names (Bug #13378).
 

diff --git a/ingo/js/filters.js b/ingo/js/filters.js
@@ -24,28 +24,10 @@ var IngoFilters = {
                     Horde.stripeElement('filterslist');
                 },
                 onUpdate: function() {
-                    $('filtersSave').clonePosition('filterslist').appear({
-                       duration: 0.2
-                    });
-
                     HordeCore.doAction(
                         'reSortFilters',
                         {
                             sort: Object.toJSON(Sortable.sequence('filterslist'))
-                        },
-                        {
-                            callback: function() {
-                                /* Need to re-label the IDs to reflect new
-                                 * sort order. */
-                                var i = 0,
-                                    rows = $('filterslist').select('DIV.filtersRow');
-                                rows.invoke('writeAttribute', 'id', null);
-                                rows.each(function(r) {
-                                    r.writeAttribute('id', 'filtersrow_' + (i++));
-                                });
-
-                                $('filtersSave').fade({ duration: 0.2 });
-                            }
                         }
                     );
                 },

diff --git a/ingo/package.xml b/ingo/package.xml
@@ -1567,7 +1567,6 @@
    <date>2014-12-03</date>
    <license uri="http://www.horde.org/licenses/apache">ASL</license>
    <notes>
-* [mms] Rate-limit filters drag/drop changes to prevent race conditions (Bug #13819).
 * [mms] Fix filter drag/drop ordering working in basic view (Bug #13820).
 * [mms] Maildir requires UTF7-IMAP encoding for folder names (Bug #13378).
    </notes>

diff --git a/ingo/templates/basic/filters/filters.html.php b/ingo/templates/basic/filters/filters.html.php
@@ -103,7 +103,3 @@
  </p>
 </form>
 <?php endif; ?>
-
-<div id="filtersSave" style="display:none">
- <span><?php echo _("Saving...") ?></span>
-</div>
diff --git a/ingo/themes/default/screen.css b/ingo/themes/default/screen.css
@@ -27,19 +27,6 @@
     color: red;
 }
 
-#filtersSave {
-    background-color: rgba(0,0,0,0.35);
-    position: absolute;
-    z-index: 100;
-}
-#filtersSave span {
-    background-color: #ddd;
-    left: 15px;
-    padding: 5px;
-    position: absolute;
-    top: 15px;
-}
-
 /* Rules page. */
 #rule select {
     padding: 2px;