Don't normalize the email addresses toLower.

We don't do this anywhere else, technically address parts are case sensitive, and this can cause freebusy information to be unavailable when querying systems that ARE case sensitive, like Turba. See Bug: 12505
horde · Nov 23, 2013 · b12876e · b12876e
1 parent de5f41f
commit b12876e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/kronolith/lib/Api.php b/kronolith/lib/Api.php
@@ -1241,7 +1241,6 @@ public function updateAttendee($response, $sender = null)
 
         $found = false;
         $error = _("No attendees have been updated because none of the provided email addresses have been found in the event's attendees list.");
-        $sender_lcase = Horde_String::lower($sender);
 
         foreach ($atnames as $index => $attendee) {
             if ($response->getAttribute('VERSION') < 2) {
@@ -1250,14 +1249,14 @@ public function updateAttendee($response, $sender = null)
                     continue;
                 }
 
-                $attendee = Horde_String::lower($addr_ob->bare_address);
+                $attendee = $addr_ob->bare_address;
                 $name = $addr_ob->personal;
             } else {
-                $attendee = str_replace('mailto:', '', Horde_String::lower($attendee));
+                $attendee = str_replace('mailto:', '', $attendee);
                 $name = isset($atparms[$index]['CN']) ? $atparms[$index]['CN'] : null;
             }
             if ($event->hasAttendee($attendee)) {
-                if (is_null($sender) || $sender_lcase == $attendee) {
+                if (is_null($sender) || $sender == $attendee) {
                     $event->addAttendee($attendee, Kronolith::PART_IGNORE, Kronolith::responseFromICal($atparms[$index]['PARTSTAT']), $name);
                     $found = true;
                 } else {

diff --git a/kronolith/lib/Event.php b/kronolith/lib/Event.php
@@ -2460,7 +2460,7 @@ public function getLocation($user = null)
      */
     public function hasAttendee($email)
     {
-        return isset($this->attendees[Horde_String::lower($email)]);
+        return isset($this->attendees[$email]);
     }
 
     /**
@@ -2476,7 +2476,6 @@ public function hasAttendee($email)
      */
     public function addAttendee($email, $attendance, $response, $name = null)
     {
-        $email = Horde_String::lower($email);
         if ($attendance == Kronolith::PART_IGNORE) {
             if (isset($this->attendees[$email])) {
                 $attendance = $this->attendees[$email]['attendance'];