Skip to content

Commit

Permalink
This isn't always an error.
Browse files Browse the repository at this point in the history
We can have no collections sent from the client in a PARTIAL request
if the client is modifying the heartbeat/waitinterval/windowsize values.
  • Loading branch information
mrubinsk committed Feb 18, 2015
1 parent 729ae9b commit b9dde22
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions framework/ActiveSync/lib/Horde/ActiveSync/Collections.php
Expand Up @@ -732,8 +732,10 @@ public function initFullSync()
public function initPartialSync()
{
if (empty($this->_collections)) {
$this->_logger->err('No collections in collection handler, no PARTIAL allowed.');
return false;
// PARTIAL is allowed without a <collection> tag if the
// waitinterval, heartbeat, or windowsize changed.
$this->_logger->err('No collections in collection handler, loading full collection set from cache.');
$this->_collections->loadCollectionsFromCache();
}
$this->_tempSyncCache = clone $this->_cache;
$c = $this->_tempSyncCache->getCollections();
Expand Down

0 comments on commit b9dde22

Please sign in to comment.