Simplify.

horde · Jun 17, 2016 · c26517f · c26517f
1 parent 2d4faa0
commit c26517f
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/framework/ActiveSync/lib/Horde/ActiveSync/Collections.php b/framework/ActiveSync/lib/Horde/ActiveSync/Collections.php
@@ -813,16 +813,15 @@ public function initEmptySync()
      */
     public function initPartialSync()
     {
+        // Need this for all PARTIAL sync requests.
+        $this->_tempSyncCache = clone $this->_cache;
+
         // PARTIAL is allowed without a <collection> tag if the waitinterval,
         // heartbeat, or windowsize changed. So, short circuit the logic for
         // checking for changed collections in this case.
         if (empty($this->_collections)) {
             $this->_logger->info('No collections in collection handler, loading full collection set from cache.');
             $this->loadCollectionsFromCache();
-
-            // Need this for all PARTIAL sync requests.
-            $this->_tempSyncCache = clone $this->_cache;
-
             foreach ($this->_collections as $value) {
                 // Remove keys from confirmed synckeys array and count them
                 if (isset($value['synckey'])) {
@@ -845,7 +844,6 @@ public function initPartialSync()
             return true;
         }
 
-        $this->_tempSyncCache = clone $this->_cache;
         $c = $this->_tempSyncCache->getCollections();
         foreach ($this->_collections as $key => $value) {
             // Collections from cache might not all have synckeys.