Better way of checking for duplicates

horde · Jan 13, 2015 · c9b2e58 · c9b2e58
1 parent dd2beb7
commit c9b2e58
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 24 deletions.
diff --git a/framework/Support/test/Horde/Support/GuidTest.php b/framework/Support/test/Horde/Support/GuidTest.php
@@ -26,18 +26,12 @@ public function testFormat()
     public function testDuplicates()
     {
         $values = array();
-        $cnt = 0;
 
         for ($i = 0; $i < 10000; ++$i) {
             $id = strval(new Horde_Support_Guid());
-            if (isset($values[$id])) {
-                $cnt++;
-            } else {
-                $values[$id] = 1;
-            }
+            $this->assertArrayNotHasKey($id, $values);
+            $values[$id] = 1;
         }
-
-        $this->assertEquals(0, $cnt);
     }
 
     public function testOptions()

diff --git a/framework/Support/test/Horde/Support/RandomidTest.php b/framework/Support/test/Horde/Support/RandomidTest.php
@@ -24,17 +24,11 @@ public function testLength()
     public function testDuplicates()
     {
         $values = array();
-        $cnt = 0;
 
         for ($i = 0; $i < 10000; ++$i) {
             $id = strval(new Horde_Support_Randomid());
-            if (isset($values[$id])) {
-                $cnt++;
-            } else {
-                $values[$id] = 1;
-            }
+            $this->assertArrayNotHasKey($id, $values);
+            $values[$id] = 1;
         }
-
-        $this->assertEquals(0, $cnt);
     }
 }
diff --git a/framework/Support/test/Horde/Support/UuidTest.php b/framework/Support/test/Horde/Support/UuidTest.php
@@ -24,17 +24,11 @@ public function testLength()
     public function testDuplicates()
     {
         $values = array();
-        $cnt = 0;
 
         for ($i = 0; $i < 10000; ++$i) {
             $id = strval(new Horde_Support_Uuid());
-            if (isset($values[$id])) {
-                $cnt++;
-            } else {
-                $values[$id] = 1;
-            }
+            $this->assertArrayNotHasKey($id, $values);
+            $values[$id] = 1;
         }
-
-        $this->assertEquals(0, $cnt);
     }
 }