Skip column modification if result would be the same.

horde · Feb 24, 2014 · d03026b · d03026b
1 parent e9e434d
commit d03026b
Showing 1 changed file with 19 additions and 9 deletions.
diff --git a/framework/Db/lib/Horde/Db/Adapter/Oracle/Schema.php b/framework/Db/lib/Horde/Db/Adapter/Oracle/Schema.php
@@ -444,6 +444,24 @@ public function changeColumn($tableName, $columnName, $type, $options = array())
             return;
         }
 
+        $old = $this->typeToSql(
+            $column->getType(),
+            is_null($options['limit']) ? null : $column->getLimit(),
+            is_null($options['precision']) ? null : $column->precision(),
+            is_null($options['scale']) ? null : $column->scale(),
+            is_null($options['unsigned']) ? null : $column->isUnsigned()
+        );
+        $new = $this->typeToSql(
+            $type,
+            $options['limit'],
+            $options['precision'],
+            $options['scale'],
+            $options['unsigned']
+        );
+        if ($old == $new) {
+            return;
+        }
+
         if ($type == 'autoincrementKey') {
             try {
                 $this->removePrimaryKey($tableName);
@@ -511,15 +529,7 @@ public function changeColumn($tableName, $columnName, $type, $options = array())
             return;
         }
 
-        $sql = $this->quoteColumnName($columnName)
-            . ' '
-            . $this->typeToSql(
-                $type,
-                $options['limit'],
-                $options['precision'],
-                $options['scale'],
-                $options['unsigned']
-            );
+        $sql = $this->quoteColumnName($columnName) . ' ' . $new;
         $sql = $this->addColumnOptions($sql, $options);
 
         $sql = sprintf(