Skip to content

Commit

Permalink
Don't use singleton Variables object.
Browse files Browse the repository at this point in the history
This may already have been altered, so get a pristine instance of the request
variables.
This was a real-world problem when clicking on "Show All Parts".
  • Loading branch information
yunosh committed Nov 19, 2014
1 parent f0bc789 commit f0b845c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion framework/Core/lib/Horde.php
Expand Up @@ -728,7 +728,7 @@ public static function selfUrlParams(array $opts = array())
{
$vars = isset($opts['vars'])
? $opts['vars']
: $GLOBALS['injector']->getInstance('Horde_Variables');
: $GLOBALS['injector']->createInstance('Horde_Variables');

$url = self::selfUrl(
false,
Expand Down

0 comments on commit f0b845c

Please sign in to comment.