Fix ordering tags.

horde · Mar 9, 2017 · f745902 · f745902
1 parent 8cbb8ed
commit f745902
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/framework/Refactor/lib/Horde/Refactor/Rule/FileLevelDocBlock.php b/framework/Refactor/lib/Horde/Refactor/Rule/FileLevelDocBlock.php
@@ -328,14 +328,17 @@ protected function _checkDocBlock($which)
 
         // Update tags order.
         $tags = array();
-        $oldTags = new \ArrayIterator($docblock->getTags());
+        $oldTags = $docblock->getTags();
         foreach (array_keys($this->_config->{$which . 'Tags'}) as $tagName) {
-            foreach ($oldTags as $key => $tag) {
+            $tmp = array();
+            foreach ($oldTags as $tag) {
                 if ($tag->getName() == $tagName) {
                     $tags[] = $tag;
-                    unset($oldTags[$key]);
+                } else {
+                    $tmp[] = $tag;
                 }
             }
+            $oldTags = $tmp;
         }
         foreach ($oldTags as $key => $tag) {
             $tags[] = $tag;