[mms] Fix harmless undefined error when accessing certain configurati…

…on parameters.
horde · May 17, 2014 · ff98e20 · ff98e20
1 parent 0aeb3bc
commit ff98e20
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/framework/Smtp/lib/Horde/Smtp.php b/framework/Smtp/lib/Horde/Smtp.php
@@ -252,7 +252,8 @@ public function getParam($key)
         switch ($key) {
         case 'password':
         case 'xoauth2_token':
-            if ($this->_params[$key] instanceof Horde_Smtp_Password) {
+            if (isset($this->_params[$key]) &&
+                ($this->_params[$key] instanceof Horde_Smtp_Password)) {
                 return $this->_params[$key]->getPassword();
             }
 

diff --git a/framework/Smtp/package.xml b/framework/Smtp/package.xml
@@ -21,6 +21,7 @@
  </stability>
  <license uri="http://www.horde.org/licenses/lgpl21">LGPL-2.1</license>
  <notes>
+* [mms] Fix harmless undefined error when accessing certain configuration parameters.
 * [mms] Horde_Smtp#send() now returns recipient status information if at least one recipient was successfully accepted.
 * [mms] Added an LMTP (RFC 2033) driver.
 * [jan] Add Hungarian translation (Andras Galos &lt;galosa@netinform.hu&gt;).
@@ -375,6 +376,7 @@
    <date>2014-05-14</date>
    <license uri="http://www.horde.org/licenses/lgpl21">LGPL-2.1</license>
    <notes>
+* [mms] Fix harmless undefined error when accessing certain configuration parameters.
 * [mms] Horde_Smtp#send() now returns recipient status information if at least one recipient was successfully accepted.
 * [mms] Added an LMTP (RFC 2033) driver.
 * [jan] Add Hungarian translation (Andras Galos &lt;galosa@netinform.hu&gt;).